Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add detailed type annotations to AstroUserConfig #2698

Merged
merged 2 commits into from
Mar 2, 2022
Merged

Add detailed type annotations to AstroUserConfig #2698

merged 2 commits into from
Mar 2, 2022

Conversation

FredKSchott
Copy link
Member

@changeset-bot
Copy link

changeset-bot bot commented Mar 2, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 87ebeec

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Mar 2, 2022
@FredKSchott FredKSchott force-pushed the wip-docs-autogenerate branch 3 times, most recently from 8ef4403 to 2942ae7 Compare March 2, 2022 01:00
tony-sull
tony-sull approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@tony-sull tony-sull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 👍

natemoo-re
natemoo-re approved these changes Mar 2, 2022
View reviewed changes
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@FredKSchott FredKSchott merged commit f957e46 into main Mar 2, 2022
@FredKSchott FredKSchott deleted the wip-docs-autogenerate branch March 2, 2022 20:09
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@FredKSchott
Add detailed type annotations to AstroUserConfig (withastro#2698)
7cefe45 
* add detailed type definitions

* final cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@natemoo-re natemoo-re natemoo-re approved these changes

@tony-sull tony-sull tony-sull approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FredKSchott @natemoo-re @tony-sull