fix astro scoping of "@import" inside of style tags #2656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: cdb4a37 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
matthewp
reviewed
Feb 25, 2022
examples/fast-build/package.json
Outdated
| "build": "astro build --experimental-static-build", | ||
| "scan-build": "astro build", | ||
| "scan-build": "astro build --experimental-static-build", |
There was a problem hiding this comment.
this is called "scan-build" because I wanted to test the old legacy build vs. the static build when it was first being developed. Can probably just drop this script now, it's not needed.
There was a problem hiding this comment.
ah, apologies! I'll remove for now
|
Let's talk about this tomorrow. I had originally done something similar but stopped doing so because I thought that scoping the external styles was the desired behavior. |
natemoo-re
approved these changes
Feb 25, 2022
Merged
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* fix astro scoping of "@import" inside of style tags * Create lovely-lies-dress.md * Update compile.ts * fix smoke test * Update package.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing
--experimental-static-build. @matthewp is it better to add the new test commented out, for when we migrate over tests?Docs