Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Non-HTML Pages example #2637

Merged
merged 3 commits into from
Feb 25, 2022
Merged

Conversation

leoj3n
Copy link
Contributor

@leoj3n leoj3n commented Feb 21, 2022

@changeset-bot
Copy link

changeset-bot bot commented Feb 21, 2022

⚠️ No Changeset found

Latest commit: 7bae87b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Feb 21, 2022
@FredKSchott FredKSchott merged commit c46db4e into withastro:main Feb 25, 2022
@FredKSchott
Copy link
Member

thank you!

@FredKSchott
Copy link
Member

BTW I cleaned up the example a bit to work in build as well as dev. When you build your site, there is no dev server running, so calling fetch() during build does nothing work. These generated files are best used on the frontend, while import and fetchContent are best used in your frontmatter.

5370bba

@leoj3n leoj3n deleted the non-html-example branch February 25, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants