Fixed incorrect types and imports #2630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: af8496b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
FredKSchott
reviewed
Feb 22, 2022
| import type { z } from 'zod'; | ||
| import type { AstroConfigSchema } from '../core/config'; | ||
| import type { AstroComponentFactory, Metadata } from '../runtime/server'; | ||
| import type vite from '../core/vite'; | ||
| import type * as vite from 'vite'; |
There was a problem hiding this comment.
The idea was to make it easy to switch in & out our own fork of Vite, if we hit a blocking Vite bug. However, I checked out vite.ts and its a pretty simple file to add back in later, so I'm okay with this change. Just calling it out for others.
Merged
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* Fixed incorrect types and imports * Changeset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
When using pnpm + typescript without
allowSyntheticDefaultImports, these errors where thrown:The first one is solved by #2628, while this PR aims to fix the rest of them
Testing
Docs