Run all smoke tests with the static build #2609
Conversation
|
|
This is the same bug tripping me up in https://github.com/withastro/astro/runs/5252193656. Seems like the |
|
This PR isn't expected to pass until astro.build converts to the static build. |
|
Static build support merged in withastro/astro.build#29 |
|
Let's hold off on merge until the release, just in the off-chance this is flakey I don't want it holding up other PRs. |
There was a problem hiding this comment.
Since --experimental-static-build changes behavior, we should probably move this flag into the package.json of each example. ie:
- "build": "astro build",
+ "build": "astro build --experimental-static-build",These get run directly by users via astro.new, so I'd be worried about them passing CI but failing when users actually go to run them. If the package.json were updated instead, our CI can trust that yarn build does the right thing for each project.
|
I don't think we should opt users into an experimental flag on all new projects. The goal of this PR is to ensure that the the experimental flag works on all of the examples. This runs both builds, so we know that both work with |
* Run all smoke tests with the static build * Use a direct relative path * Always use the static build * Use a path that works in both static and regualr build * Always download the zip * astro.build only needs to run once
Changes
Testing
All of the examples that are smoke tested are also run with `--experimental-static-build flag.
Docs
Test only