Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix component usage in portfolio-svelte 404 page #2549

Merged
merged 2 commits into from
Mar 10, 2022

Conversation

mastercoms
Copy link
Contributor

Changes

  • Uses the correct casing for the Svelte components, rather than HTML tags

Testing

  • Tested visiting a 404 page, and the navbar and footer now display properly.

Docs

  • Bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Feb 8, 2022

⚠️ No Changeset found

Latest commit: 0b61719

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Feb 8, 2022
Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@natemoo-re natemoo-re merged commit 52d812b into withastro:main Mar 10, 2022
@mastercoms mastercoms deleted the patch-1 branch March 12, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants