Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handles all http error code file names the same as 404 files. #2525

Merged
merged 2 commits into from
Feb 3, 2022
Merged

Handles all http error code file names the same as 404 files. #2525

merged 2 commits into from
Feb 3, 2022

Conversation

zadeviggers
Copy link
Contributor

Changes

Handles all http error code file names the same as 404 files.
Fixes #2195.

  • What does this change?
  • Be short and concise. Bullet points can help!
  • Before/after screenshots can be helpful as well.

Testing

I don't think test changes are necessary, although if I knew how I would add extra tests to make sure that all of the HTTP status code files are generated correctly.

Docs

Bug fix only.

@changeset-bot
Copy link

changeset-bot bot commented Feb 3, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: 95947d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 3, 2022
@netlify
Copy link

netlify bot commented Feb 3, 2022 •
edited
Loading

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: 95947d3

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61fb42271253d000084c8639

😎 Browse the preview: https://deploy-preview-2525--astro-docs-2.netlify.app

FredKSchott
FredKSchott approved these changes Feb 3, 2022
View reviewed changes
Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! After merging I might improve this to just check for XXX.astro, even if that's not 100% correct it will probably be easier to test and reason about.

@FredKSchott FredKSchott merged commit ed4969d into withastro:main Feb 3, 2022
@natemoo-re natemoo-re mentioned this pull request Mar 4, 2022
Merged
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@zadeviggers
Handles all http error code file names the same as 404 files. (withas…
e90e12f 
…tro#2525)

* Fix withastro#2195

* Filter out error code files from sitemap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FredKSchott FredKSchott FredKSchott approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🐛 BUG: 4xx added to sitemap, built in directory
2 participants
@zadeviggers @FredKSchott