Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sitemap): remove debug message if sitemap disabled #2514

Merged
merged 1 commit into from
Feb 3, 2022

Conversation

markpinero
Copy link
Contributor

Changes

Verbose builds erroneously says "Sitemap built" even if sitemap is disabled in config.

Testing

No tests, just moved debug inside if block.

Docs

bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Feb 1, 2022

⚠️ No Changeset found

Latest commit: 67d371d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Feb 1, 2022
@netlify
Copy link

netlify bot commented Feb 1, 2022

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: 67d371d

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61f89c0b47ce990008b9d1e9

😎 Browse the preview: https://deploy-preview-2514--astro-docs-2.netlify.app

Copy link
Member

@FredKSchott FredKSchott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch! LGTM!

@FredKSchott FredKSchott merged commit 81238bf into withastro:main Feb 3, 2022
@markpinero markpinero deleted the fix/sitemap-debug-message branch February 3, 2022 21:38
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants