Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue rendering content within HTMLElement #2506

Merged

Conversation

jonathantneal
Copy link
Contributor

Changes

  • Updates renderHTMLElement method to support children like renderComponent.

Testing

bug fix only

Docs

bug fix only

@changeset-bot
Copy link

changeset-bot bot commented Jan 31, 2022

🦋 Changeset detected

Latest commit: 6b98b32

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jan 31, 2022
@netlify
Copy link

netlify bot commented Jan 31, 2022

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: 6b98b32

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61f803f223c00100085ae58a

😎 Browse the preview: https://deploy-preview-2506--astro-docs-2.netlify.app

Copy link
Contributor

@matthewp matthewp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jonathantneal jonathantneal merged commit 187d512 into main Jan 31, 2022
@jonathantneal jonathantneal deleted the jn.fix-issue-rendering-content-within-htmlelement branch January 31, 2022 21:50
@github-actions github-actions bot mentioned this pull request Jan 31, 2022
@github-actions github-actions bot mentioned this pull request Feb 18, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants