Scaffold language server #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FredKSchott
reviewed
Mar 24, 2021
FredKSchott
reviewed
Mar 24, 2021
added 9 commits
March 25, 2021 10:14
1198f08
to
825a3e0
Compare
lilnasy
reviewed
Mar 15, 2024
| const end = performance.now(); | ||
| const span = end - start; | ||
|
|
||
| console.log(`✨ Built in ${Math.round(span)}ms!`); |
There was a problem hiding this comment.
Heyy, let's bring this back! I want to see sparkles when my build succeeds.
|
|
||
| async function watch() { | ||
| await Promise.all([buildClient(), buildServer()]); | ||
| console.log('👀 Watching for changes...'); |
There was a problem hiding this comment.
Beginning of something great! This PR was the stepping stone of a DX not just smooth, but friendly and welcoming!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An early pass at the Astro extension, just to get things into
main.There's a way to use this locally but I talked with @FredKSchott about just publishing the extension so y'all don't have to spin up the debugger every time you want to edit a file.
If you're curious, the bulk of the work is being done by
astro-language-configuration.jsonandastro.tmLanguage.json, both of which are referenced here in the extension'spackage.json.