Fix pre-generated RSS URLs #2443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3e210dc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
pkg: astro
jonathantneal
approved these changes
Jan 21, 2022
|
✔️ Deploy Preview for astro-docs-2 ready! 🔨 Explore the source changes: 8dbce80 🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61eb3019e4139e000736d6a1 😎 Browse the preview: https://deploy-preview-2443--astro-docs-2.netlify.app |
Merged
|
Woah, thanks for doing this! Sorry I went dark - some real life stuff came up. |
SiriousHunter
pushed a commit
to SiriousHunter/astro
that referenced
this pull request
Feb 3, 2023
* Allow pre-generated urls to be passed in rss feeds * Fix variable name * Add isValidURL helper function * Remove scary RegEx and tidy up code * add test for using pregenerated urls * fix: allow rss to be called multiple times * test: normalize rss feed in test * chore: add changeset Co-authored-by: Zade Viggers <[email protected]> Co-authored-by: zadeviggers <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
rss()could not be called multiple timesTesting
Docs
Bug fix only