Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass user's viteConfig.ssr to the build #2442

Merged
merged 2 commits into from
Jan 24, 2022
Merged

Pass user's viteConfig.ssr to the build #2442

merged 2 commits into from
Jan 24, 2022

Conversation

matthewp
Copy link
Contributor

Changes

  • In the static build, include a user's own vite.ssr configuration, so they can control external and noExternal config.

Testing

Test added

Docs

Bug fix

@changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2022

🦋 Changeset detected

Latest commit: eb2d1e4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) test labels Jan 21, 2022
@netlify
Copy link

netlify bot commented Jan 21, 2022

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: 77826f8

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61eb26d1c40f560008547ffc

😎 Browse the preview: https://deploy-preview-2442--astro-docs-2.netlify.app

@netlify
Copy link

netlify bot commented Jan 21, 2022

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: eb2d1e4

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61eb26ef373a1c00072aa5ed

😎 Browse the preview: https://deploy-preview-2442--astro-docs-2.netlify.app

Copy link
Contributor

@jonathantneal jonathantneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice feature. Awesome tests.

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree with Jonathan!

@matthewp matthewp merged commit dfe1f8b into main Jan 24, 2022
@matthewp matthewp deleted the sb-ssr-config branch January 24, 2022 13:55
@github-actions github-actions bot mentioned this pull request Jan 24, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Pass user's viteConfig.ssr to the build

* Changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants