Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for styled RSS feeds #2371

Merged
merged 1 commit into from
Jan 19, 2022
Merged

Add support for styled RSS feeds #2371

merged 1 commit into from
Jan 19, 2022

Conversation

natemoo-re
Copy link
Member

Changes

  • Adds a new stylesheet option to the rss() function
  • Automatically injects Pretty Feed v3 if true.
  • References public/ file if a string value is used

Testing

Looks like we don't have RSS tests, would like to add

Docs

Added new section to RSS doc!

@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2022

🦋 Changeset detected

Latest commit: 69929b3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) docs labels Jan 13, 2022
@matthewp
Copy link
Contributor

👍

@netlify
Copy link

netlify bot commented Jan 13, 2022

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: 69929b3

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61e05883b3fc2700071c9d6a

😎 Browse the preview: https://deploy-preview-2371--astro-docs-2.netlify.app

Copy link
Contributor

@jasikpark jasikpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wooooo fancy rss feeds :D @genmon might be interested in this


### Styling

RSS Feeds can be styled with an XSL stylesheet for a more pleasant user experience when they are opened directly in a browser. By default, Astro does not set a stylesheet for RSS feeds, but it can be enabled by setting the `stylesheet` option.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasikpark
Copy link
Contributor

https://github.com/genmon/aboutfeeds if there's anything to tweak about the XSLT 🤔

@jasikpark
Copy link
Contributor

https://natclark.com/index.xml is definitely a nice example - it makes me want to make my own custom XSLT file 👀

@matthewp
Copy link
Contributor

Arg, the test failure is one of mine. It seems to be flakey on windows. You can .skip to unblock yourself if you want.

Copy link
Contributor

@jonathantneal jonathantneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend adding @jasikpark’s suggestion in a follow. Since this is good, we can add these as-is now.

@jonathantneal
Copy link
Contributor

Running the tests again. I hope it was a fluke.

@jonathantneal
Copy link
Contributor

Tests passed. Here we go!

@jonathantneal jonathantneal merged commit 85ad1aa into main Jan 19, 2022
@jonathantneal jonathantneal deleted the feat/styled-feeds branch January 19, 2022 20:34
@github-actions github-actions bot mentioned this pull request Jan 19, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants