Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes Lit support in the static build #2370

Merged
merged 12 commits into from
Jan 14, 2022
Merged

Fixes Lit support in the static build #2370

merged 12 commits into from
Jan 14, 2022

Conversation

matthewp
Copy link
Contributor

Changes

  • Lit needs polyfills to be build and resolved when the pages are rendered. This fixes that.

Testing

  • Test added
  • Example app confirmed

Docs

N/A bug fix

@changeset-bot
Copy link

changeset-bot bot commented Jan 13, 2022

🦋 Changeset detected

Latest commit: 9ede257

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@astrojs/renderer-lit Patch
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) test labels Jan 13, 2022
@netlify
Copy link

netlify bot commented Jan 13, 2022

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: d02a78d

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61e053546328f80008856cdc

😎 Browse the preview: https://deploy-preview-2370--astro-docs-2.netlify.app

@netlify
Copy link

netlify bot commented Jan 13, 2022

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: 32a0325

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61e1b01f77d7c80007aa3d41

😎 Browse the preview: https://deploy-preview-2370--astro-docs-2.netlify.app/en/guides/markdown-content

@matthewp matthewp self-assigned this Jan 13, 2022
Comment on lines +62 to +67
const polyfills = getRenderers(opts).flatMap(renderer => {
return (renderer.polyfills || []).concat(renderer.hydrationPolyfills || []);
});
for(const polyfill of polyfills) {
jsInput.add(polyfill);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nicely done.

FredKSchott and others added 7 commits January 14, 2022 12:02
Co-authored-by: FredKSchott <[email protected]>
* Fixes for blog and docs examples

* Adds a changeset

* Upgrade the compiler version

* Use a global style tag

* Skip on windows temporarily
@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Jan 14, 2022
@github-actions github-actions bot added pkg: lit Related to Lit (scope) pkg: integration Related to any renderer integration (scope) labels Jan 14, 2022
@matthewp matthewp merged commit a796753 into main Jan 14, 2022
@matthewp matthewp deleted the sb-lit2 branch January 14, 2022 19:02
@github-actions github-actions bot mentioned this pull request Jan 14, 2022
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* [ci] collect stats

* [ci] update lockfile (withastro#2388)

Co-authored-by: FredKSchott <[email protected]>

* Fixes for blog and docs examples (withastro#2373)

* Fixes for blog and docs examples

* Adds a changeset

* Upgrade the compiler version

* Use a global style tag

* Skip on windows temporarily

* [ci] yarn format

* Fixes Lit support in the static build

* Adds a changeset

* test

* Upgrade lit-labs/ssr

* Conditional

* Testing again

* remove debugging code

* changeset

Co-authored-by: FredKSchott <[email protected]>
Co-authored-by: Fred K. Schott <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) pkg: integration Related to any renderer integration (scope) pkg: lit Related to Lit (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants