Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix for shared CSS when using the static build #2365

Merged
merged 2 commits into from
Jan 12, 2022
Merged

Fix for shared CSS when using the static build #2365

merged 2 commits into from
Jan 12, 2022
+262 −22

Conversation

matthewp
Copy link
Contributor

Changes

  • Fixes when there are shared CSS chunks between pages, in the static build.
  • Also fixes when importing CSS modules
  • Gets the portfolio example working

Testing

Tests added

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Jan 12, 2022 •
edited
Loading

🦋 Changeset detected

Latest commit: 0875105

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) test labels Jan 12, 2022
matthewp
matthewp commented Jan 12, 2022
View reviewed changes
examples/portfolio/src/components/MainHead.astro
@@ -1,4 +1,5 @@
---
import '../styles/global.scss';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that we can change this to use local:src when that is implemented.

@netlify
Copy link

netlify bot commented Jan 12, 2022

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: c1bb1e3

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61defebc0818a000073fa7cb

😎 Browse the preview: https://deploy-preview-2365--astro-docs-2.netlify.app

@netlify
Copy link

netlify bot commented Jan 12, 2022

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: 0875105

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61defef411b71500080d05ef

😎 Browse the preview: https://deploy-preview-2365--astro-docs-2.netlify.app

jonathantneal
jonathantneal approved these changes Jan 12, 2022
View reviewed changes
Copy link
Contributor

@jonathantneal jonathantneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The createFindEvidence had me nervous until I realized it was only a testing util.

👍

@matthewp matthewp merged commit 20d0cce into main Jan 12, 2022
@matthewp matthewp deleted the static-build-portfolio branch January 12, 2022 17:02
@github-actions github-actions bot mentioned this pull request Jan 12, 2022
Merged
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@matthewp
Fix for shared CSS when using the static build (withastro#2365)
55b4368 
* Fix for shared CSS when using the static build

* Adds a changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonathantneal jonathantneal jonathantneal approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthewp @jonathantneal