Fix build output in static build mode #2358
Conversation
🦋 Changeset detectedLatest commit: 57b4809 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
pkg: astro
|
✔️ Deploy Preview for astro-www ready! 🔨 Explore the source changes: 12baa35 🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/61dd9c765df7b10007e61920 😎 Browse the preview: https://deploy-preview-2358--astro-www.netlify.app |
|
✔️ Deploy Preview for astro-docs-2 ready! 🔨 Explore the source changes: 12baa35 🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61dd9c767d31f40008a571fe 😎 Browse the preview: https://deploy-preview-2358--astro-docs-2.netlify.app |
|
✔️ Deploy Preview for astro-www ready! 🔨 Explore the source changes: 57b4809 🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/61ddaa412508e4000885bdb8 😎 Browse the preview: https://deploy-preview-2358--astro-www.netlify.app |
|
✔️ Deploy Preview for astro-docs-2 ready! 🔨 Explore the source changes: 57b4809 🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61ddaa413c8c950008bcded5 😎 Browse the preview: https://deploy-preview-2358--astro-docs-2.netlify.app |
| const { Component, internals, linkIds, pageData } = gopts; | ||
|
|
||
| // This adds the page name to the array so it can be shown as part of stats. | ||
| addPageName(pathname, opts); |
There was a problem hiding this comment.
It looks like prettier/eslint did not catch this. I can’t recall if these are auto-fixed after merge.
There was a problem hiding this comment.
We disabled prettier to run in CI a while back because it was breaking releases (it would format in main after merging the release PR). We should probably add it back and have it only run in non-main branches.
There was a problem hiding this comment.
I ran yarn format and pushed the changes here. It's odd that EditorConfig didn't correct this.
* Fix build output in static build mode * Adds a changeset * Formatting
Changes
--experimental-static-build. Previously was missing the number of pages, now its fixed:Testing
We don't have tests for cli output at the moment.
Docs
N/A, bug fix only.