Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle loading the Code package in the static build #2337

Merged
merged 5 commits into from
Jan 7, 2022

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Jan 7, 2022

Fixes #2329

Changes

  • Fixes using import {Code} from 'astro/components' in the static build.

Testing

Test added

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2022

🦋 Changeset detected

Latest commit: 8129343

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) test labels Jan 7, 2022
@netlify
Copy link

netlify bot commented Jan 7, 2022

✔️ Deploy Preview for astro-www ready!

🔨 Explore the source changes: d52334d

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/61d8a4a8f12f82000a637af2

😎 Browse the preview: https://deploy-preview-2337--astro-www.netlify.app

@netlify
Copy link

netlify bot commented Jan 7, 2022

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: d52334d

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61d8a4a8f1de2f0008bef88a

😎 Browse the preview: https://deploy-preview-2337--astro-docs-2.netlify.app

@netlify
Copy link

netlify bot commented Jan 7, 2022

✔️ Deploy Preview for astro-www ready!

🔨 Explore the source changes: 8129343

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/61d8adaf0bcdce0007d4d7d2

😎 Browse the preview: https://deploy-preview-2337--astro-www.netlify.app

@netlify
Copy link

netlify bot commented Jan 7, 2022

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: 8129343

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61d8adaf5d12b800083dce49

😎 Browse the preview: https://deploy-preview-2337--astro-docs-2.netlify.app

Copy link
Contributor

@jonathantneal jonathantneal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

examples/fast-build/src/pages/index.astro Outdated Show resolved Hide resolved
@matthewp matthewp merged commit 180dfcf into main Jan 7, 2022
@matthewp matthewp deleted the static-build-external-astro branch January 7, 2022 21:28
@github-actions github-actions bot mentioned this pull request Jan 7, 2022
jonathantneal pushed a commit that referenced this pull request Jan 8, 2022
* Handle loading the Code package

Fixes #2329

* Use Code the normal way

* Adds a changeset

* Only resolve browser path if there is no common ancestor

* Update examples/fast-build/src/pages/index.astro

Co-authored-by: Nate Moore <[email protected]>

Co-authored-by: Nate Moore <[email protected]>
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Handle loading the Code package

Fixes withastro#2329

* Use Code the normal way

* Adds a changeset

* Only resolve browser path if there is no common ancestor

* Update examples/fast-build/src/pages/index.astro

Co-authored-by: Nate Moore <[email protected]>

Co-authored-by: Nate Moore <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: static build breaks when package contains .astro
3 participants