Fix dynamic routes for sites with subpath #2299
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
The route being passed into
ssrOptions
included the configured site pathname and therefore failed to match any patterns in the available routes when trying to extract parameters. This made it so that every valid dynamic route would error withroute pattern matched, but no matching static path found.
Testing
I added tests for all the scenarios currently being tested under
Dynamic Routing
for both valid and invalid dynamic routes.Docs
No documentation changes should be required since it's only a bug fix.