Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Implement hydrated components in the static build (#2260)" #2292

Merged
merged 2 commits into from
Dec 30, 2021
Merged

Revert "Implement hydrated components in the static build (#2260)" #2292

merged 2 commits into from
Dec 30, 2021

Conversation

matthewp
Copy link
Contributor

This reverts commit ae5255d.

Changes

  • This reverts the recent static build change that implements hydrated components. For some reason it was causing the docs site to break, so reverting until we can investigate why.

Testing

N/A

Docs

N/A

@changeset-bot
Copy link

changeset-bot bot commented Dec 30, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: 813b8fc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope) test labels Dec 30, 2021
@netlify
Copy link

netlify bot commented Dec 30, 2021

✔️ Deploy Preview for astro-www ready!

🔨 Explore the source changes: 17ac18e

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/61cddf4d41194f00083a7a63

😎 Browse the preview: https://deploy-preview-2292--astro-www.netlify.app

@netlify
Copy link

netlify bot commented Dec 30, 2021

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: 17ac18e

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61cddf4dccae050008c71b2b

😎 Browse the preview: https://deploy-preview-2292--astro-docs-2.netlify.app

@netlify
Copy link

netlify bot commented Dec 30, 2021

✔️ Deploy Preview for astro-www ready!

🔨 Explore the source changes: 813b8fc

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/61cddf763700db0007824633

😎 Browse the preview: https://deploy-preview-2292--astro-www.netlify.app

@netlify
Copy link

netlify bot commented Dec 30, 2021

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: 813b8fc

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61cddf7681003a00075c15cb

😎 Browse the preview: https://deploy-preview-2292--astro-docs-2.netlify.app

@aFuzzyBear
Copy link
Contributor

It works like a charm @matthewp, is this another one I can approve?
Trying to set a new PB before the end of the year, 😅

aFuzzyBear
aFuzzyBear approved these changes Dec 30, 2021
View reviewed changes
Copy link
Contributor

@aFuzzyBear aFuzzyBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the quick fix @matthewp,

@matthewp matthewp merged commit 2e55dc2 into main Dec 30, 2021
@matthewp matthewp deleted the fix-docs2 branch December 30, 2021 16:52
@github-actions github-actions bot mentioned this pull request Dec 30, 2021
Merged
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@matthewp
Revert "Implement hydrated components in the static build (withastro#…
ccc6ffc 
…2260)" (withastro#2292)

* Revert "Implement hydrated components in the static build (withastro#2260)"

This reverts commit ae5255d.

* Adds a changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aFuzzyBear aFuzzyBear aFuzzyBear approved these changes

Assignees
No one assigned
Labels
pkg: astro Related to the core `astro` package (scope) pkg: example Related to an example package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthewp @aFuzzyBear