Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(lit): add reflected property tests #2116

Merged
merged 1 commit into from
Dec 6, 2021

Conversation

e111077
Copy link
Contributor

@e111077 e111077 commented Dec 3, 2021

Changes

  • Adds lit-renderer reflection tests

Testing

This is only tests following up on #1874

Docs

tests only

Also please lmk if this is even supposed to be a patch or whether to just remove the changeset

@changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2021

🦋 Changeset detected

Latest commit: 1513588

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) test labels Dec 3, 2021
@netlify
Copy link

netlify bot commented Dec 3, 2021

✔️ Deploy Preview for astro-www ready!

🔨 Explore the source changes: 1513588

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/61aa86eb67f76600075a8c56

😎 Browse the preview: https://deploy-preview-2116--astro-www.netlify.app

@netlify
Copy link

netlify bot commented Dec 3, 2021

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: 1513588

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61aa86eb8a6d1900082cfd7b

😎 Browse the preview: https://deploy-preview-2116--astro-docs-2.netlify.app

@natemoo-re
Copy link
Member

natemoo-re commented Dec 5, 2021

Thanks for following up with some improved tests! I'll take a closer look on Monday.

You can remove the changeset, we aren't currently tracking test coverage changes as version bumps.

Don't worry about the failing macOS test suite, that's a flaky test on our end.

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks so much!

@natemoo-re natemoo-re merged commit d9d3906 into withastro:main Dec 6, 2021
@github-actions github-actions bot mentioned this pull request Dec 6, 2021
vineryap pushed a commit to vineryap/astro that referenced this pull request Dec 22, 2021
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants