Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make aliases work on windows #2109

Merged
merged 6 commits into from
Dec 3, 2021
Merged

Make aliases work on windows #2109

merged 6 commits into from
Dec 3, 2021

Conversation

Mikkel-T
Copy link
Contributor

@Mikkel-T Mikkel-T commented Dec 3, 2021

Changes

  • Change all occurrences of path.posix to path.

Testing

Docs

@Mikkel-T
Make aliases work on windows
5df4825 
Change all occurrences of path.posix to path.
@changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2021 •
edited
Loading

🦋 Changeset detected

Latest commit: f9a0948

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Dec 3, 2021
@netlify
Copy link

netlify bot commented Dec 3, 2021 •
edited
Loading

✔️ Deploy Preview for astro-www ready!

🔨 Explore the source changes: f9a0948

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/61aa3d49dac2360007f55ea7

😎 Browse the preview: https://deploy-preview-2109--astro-www.netlify.app

@netlify
Copy link

netlify bot commented Dec 3, 2021 •
edited
Loading

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: f9a0948

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61aa3d490849da0007098b92

😎 Browse the preview: https://deploy-preview-2109--astro-docs-2.netlify.app

@matthewp
Copy link
Contributor

matthewp commented Dec 3, 2021

Just need to remove the console.log, otherwise looks great!

@Mikkel-T
Copy link
Contributor Author

Mikkel-T commented Dec 3, 2021

😅 Oops!

@jonathantneal jonathantneal merged commit 3e4cfea into withastro:main Dec 3, 2021
@jonathantneal jonathantneal self-assigned this Dec 3, 2021
@jonathantneal
Copy link
Contributor

Hey all, @Mikkel-T and I paired on this over Discord and get the fix worked out. Thanks, @Mikkel-T!

@Mikkel-T Mikkel-T deleted the fix-windows-aliases branch December 3, 2021 21:22
@github-actions github-actions bot mentioned this pull request Dec 3, 2021
Merged
vineryap pushed a commit to vineryap/astro that referenced this pull request Dec 22, 2021
@Mikkel-T @vineryap
Make aliases work on windows (withastro#2109)
6b0c575 
* Make aliases work on windows

Change all occurrences of path.posix to path.

* Remove console log statement

* Update index.ts

* Update index.ts

* Update index.ts

* Edit changeset
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
@Mikkel-T
Make aliases work on windows (withastro#2109)
97d8b96 
* Make aliases work on windows

Change all occurrences of path.posix to path.

* Remove console log statement

* Update index.ts

* Update index.ts

* Update index.ts

* Edit changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewp matthewp matthewp left review comments

@jonathantneal jonathantneal jonathantneal approved these changes

Assignees

@jonathantneal jonathantneal

Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mikkel-T @matthewp @jonathantneal