Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of URL module in runtime #2107

Merged
merged 2 commits into from
Dec 3, 2021
Merged

Remove use of URL module in runtime #2107

merged 2 commits into from
Dec 3, 2021

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Dec 3, 2021

Changes

Testing

Bug only occurs externally

Docs

Bug fix

We can't use this module due to Vite not having a shim and this needing
to run inside Vite.
@changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2021

🦋 Changeset detected

Latest commit: 7bc6046

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
astro Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Dec 3, 2021
@matthewp matthewp merged commit 4c44467 into main Dec 3, 2021
@matthewp matthewp deleted the remove-url branch December 3, 2021 14:13
@github-actions github-actions bot mentioned this pull request Dec 3, 2021
matthewp added a commit that referenced this pull request Dec 6, 2021
* Remove use of URL module

We can't use this module due to Vite not having a shim and this needing
to run inside Vite.

* Adding a changeset
vineryap pushed a commit to vineryap/astro that referenced this pull request Dec 22, 2021
* Remove use of URL module

We can't use this module due to Vite not having a shim and this needing
to run inside Vite.

* Adding a changeset
SiriousHunter pushed a commit to SiriousHunter/astro that referenced this pull request Feb 3, 2023
* Remove use of URL module

We can't use this module due to Vite not having a shim and this needing
to run inside Vite.

* Adding a changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 BUG: Astro build fails for the blog starter example
1 participant