Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Solid to with-nanostores example #2079

Merged
merged 1 commit into from
Dec 13, 2021

Conversation

agustinmulet
Copy link
Contributor

Changes

This changes adds Solid to the nanostores example, also improves the Svelte component and naming on others.

Testing

No tests were added since this example doesn't have tests.

Docs

Docs weren't updated.

@changeset-bot
Copy link

changeset-bot bot commented Dec 1, 2021

⚠️ No Changeset found

Latest commit: ceed1af

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Dec 1, 2021

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: ceed1af

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/61a80aae4d408400077eb943

😎 Browse the preview: https://deploy-preview-2079--astro-docs-2.netlify.app

@netlify
Copy link

netlify bot commented Dec 1, 2021

✔️ Deploy Preview for astro-www ready!

🔨 Explore the source changes: ceed1af

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/61a80aae3ea86f0008a64bfb

😎 Browse the preview: https://deploy-preview-2079--astro-www.netlify.app

@github-actions github-actions bot added the pkg: example Related to an example package (scope) label Dec 1, 2021
@FredKSchott
Copy link
Member

LGTM!

@FredKSchott FredKSchott merged commit 23b7756 into withastro:main Dec 13, 2021
vineryap pushed a commit to vineryap/astro that referenced this pull request Dec 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: example Related to an example package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants