Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: header logo/nav/svg #1845

Merged
merged 1 commit into from
Nov 17, 2021
Merged

fix: header logo/nav/svg #1845

merged 1 commit into from
Nov 17, 2021

Conversation

johneatmon
Copy link
Contributor

@johneatmon johneatmon commented Nov 16, 2021

Changes

Overall, improve Astro's site header:

  • Remove duplicate h1 tag (an h1 tag was in header and main).
  • Remove article tags from header.
  • Improved accessibility for the SVG logo, per guidelines from this CSS Tricks article.
  • Restructure navigation links into an unordered list with list role, guidelines from 5t3ph's HTML Recipes.
  • Add Logo structured data because...why not?

Testing

Ran astro build — no build errors 😁

Docs

None changed

@johneatmon johneatmon requested a review from a team as a code owner November 16, 2021 20:37
@changeset-bot
Copy link

changeset-bot bot commented Nov 16, 2021

⚠️ No Changeset found

Latest commit: d152556

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Nov 16, 2021

✔️ Deploy Preview for astro-www ready!

🔨 Explore the source changes: d152556

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-www/deploys/6195621eab91170007ce1c26

😎 Browse the preview: https://deploy-preview-1845--astro-www.netlify.app

@netlify
Copy link

netlify bot commented Nov 16, 2021

✔️ Deploy Preview for astro-docs-2 ready!

🔨 Explore the source changes: d152556

🔍 Inspect the deploy log: https://app.netlify.com/sites/astro-docs-2/deploys/6195621ebd1a7700072533b7

😎 Browse the preview: https://deploy-preview-1845--astro-docs-2.netlify.app

@github-actions github-actions bot added the www label Nov 16, 2021
@justinnoel
Copy link

Nice looking first Astro PR! Way to go @johnnytest4real !

I love how you referenced tools and guidelines!

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a wonderful PR! Approved once CI passes. 🎉

Thank you for outlining the reasoning behind these changes, that is super helpful context.

@natemoo-re natemoo-re merged commit ae553a1 into withastro:main Nov 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants