Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix running the VSCode extension #181

Merged
merged 1 commit into from
May 8, 2021
Merged

Fix running the VSCode extension #181

merged 1 commit into from
May 8, 2021

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented May 7, 2021

Changes

I'm not sure how my setup was different but I was unable to get the extension to run locally without adding a binary. This mirrors what Svelte does so I'm assuming it's the way it's supposed to be loaded.

Testing

n/a

Docs

Added a Contributing.md file to the vscode extension explaining how to get development running.

I'm not sure how my setup was different but I was unable to get the extension to run locally without adding a binary. This mirrors what Svelte does so I'm assuming it's the way it's supposed to be loaded.
@changeset-bot
Copy link

changeset-bot bot commented May 7, 2021

⚠️ No Changeset found

Latest commit: b71cfa6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR


Then in the __Debug__ panel select __Launch Extension__ from the dropdown and click the run button.

<img width="558" alt="Screen Shot 2021-05-07 at 8 51 37 AM" src="https://user-images.githubusercontent.com/361671/117452223-807e5580-af11-11eb-8404-dd615784408a.png">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we want to keep this in the project, maybe we can link it locally (./docs)? Just not sure how long these last

Copy link
Member

@drwpow drwpow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WFM

@matthewp matthewp merged commit 60e482a into main May 8, 2021
@matthewp matthewp deleted the fix-ext branch May 8, 2021 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants