Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove reference to nonexistent /guides/wasm.md #1662

Merged
merged 1 commit into from
Nov 1, 2021

Conversation

jasikpark
Copy link
Contributor

@jasikpark jasikpark commented Oct 26, 2021

Changes

Testing

Docs

Maybe we could instead actually flesh out what *using wasm with astro* means? Is this something where we could pull prior art from the playground site?
@jasikpark jasikpark requested a review from a team as a code owner October 26, 2021 20:49
@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2021

⚠️ No Changeset found

Latest commit: a6deb74

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@natemoo-re natemoo-re left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I think next will be able to point to Vite's docs on WASM instead!

@matthewp matthewp merged commit 09f69f3 into main Nov 1, 2021
@matthewp matthewp deleted the docs/remove-broken-link-to-wasm-guide branch November 1, 2021 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants