First Pass at LSP #129
Merged
First Pass at LSP #129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
April 21, 2021 16:36
|
lgtm |
drwpow
reviewed
Apr 23, 2021
|
|
||
| let docClient: lsp.LanguageClient; | ||
|
|
||
| const TagCloseRequest: lsp.RequestType<lsp.TextDocumentPositionParams, string, any> = new lsp.RequestType('html/tag'); | ||
|
|
||
| /** */ |
There was a problem hiding this comment.
The JSDoc stuff was mainly for generating docs in Astro core (or at least experimenting with it). I think it’d be safe to just disable the JSDoc rule for this whole vscode/ folder (put another .eslintrc in the root of this disabling just that rule)
drwpow
reviewed
Apr 23, 2021
vscode/packages/server/LICENSE
Outdated
| @@ -0,0 +1,37 @@ | |||
| MIT License | |||
|
|
|||
| Copyright (c) 2021 Fred K. Schott | |||
There was a problem hiding this comment.
Seems like you wrote a lot of this 🙂. Please put your name in the license here, and we can update as necessary. We probably need to do something like this in the top-level:
Portions Copyright (c) 2021 Fred K. Schott
Portions Copyright (c) 2021 Nate Moore
Portions Copyright (c) 2021 Matthew Phillips
Portions Copyright (c) 2021 Drew Powers
(others)?
There was a problem hiding this comment.
Also we probably do need to add a CLA to Astro
drwpow
reviewed
Apr 23, 2021
|
|
||
| console.log({ actions, isImport }); | ||
|
|
||
| // TODO: handle actions |
There was a problem hiding this comment.
Random comment proving I scrolled down this far 😛
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This PR includes major scaffolding for IDE support—currently our extension works for VS Code, but the back-end is implemented as an IDE-agnostic Language Server via LSP (follow up to #89)
Credit where credit is due, much of this code is adapted from Svelte's Language Tools.
Testing
No direct tests, but you can launch the extension using VS Code's debugger and selecting "Launch Extension"
Docs
TODO