Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make congratsbot not run in forks #1145

Merged
merged 1 commit into from
Aug 18, 2021
Merged

Make congratsbot not run in forks #1145

merged 1 commit into from
Aug 18, 2021

Conversation

MarcusOtter
Copy link
Member

@MarcusOtter MarcusOtter commented Aug 18, 2021

Changes

  • What does this change?
    Makes this workflow not run in forks, since it sends emails to me when it fails:
    image

Testing

I have not, and I have no idea how to test 😅

I just saw this solution in an issue on https://github.com/actions/runner/, and also that most workflows use this in quarkus.io.
Definitely test somehow before merging! (or don't, I mean, the only effect it has is that I don't get a congratulation when the PR is merged if the code is wrong)

Docs

No

@changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2021

⚠️ No Changeset found

Latest commit: c6c12a1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 18, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

astro-www – ./www

🔍 Inspect: https://vercel.com/pikapkg/astro-www/Exwa1hyF5Y8Ga2Wn7uZLQhq8Pk6Y
✅ Preview: Canceled

astro-docs – ./docs

🔍 Inspect: https://vercel.com/pikapkg/astro-docs/HfbUYuJN91Uxxm5WMswKUkBGDE2F
✅ Preview: https://astro-docs-git-fork-marcusotter-patch-2-pikapkg.vercel.app

@FredKSchott
Copy link
Member

LGTM! Only one way to test :)

@FredKSchott FredKSchott merged commit c7bbb04 into withastro:main Aug 18, 2021
FredKSchott pushed a commit that referenced this pull request Aug 18, 2021
FredKSchott added a commit that referenced this pull request Aug 18, 2021
* wip

* Add support for `client:only` hydrator (#935)

* Adding support for client:only hydration

* Adding documentation for client:only

* Adding changeset

* Updating the test to use a browser-only API

* Adding a browser-specific import script, this reproduces the issue where client:only imports must be removed

* typo fix

* removing mispelled test component

* WIP: delaying inclusion of component imports until the hydration method is known

* WIP: tweaking the test to use window instead of document

* When only one renderer is included, use that for client:only hydration

* temporary test script snuck into the last commit

* WIP: adding check for a client:only renderer hint

* refactor: Remove client:only components instead of delaying all component import statements

* Updating the changeset and docs for the renderer hint

* refactor: pull client:only render matching out to it's own function

* Updating renderer hinting to match full name, with shorthand for internal renderers

Co-authored-by: Tony Sullivan <[email protected]>

* [ci] yarn format

* Update CONTRIBUTING.md (#1131)

* [ci] yarn format

* docs: fix select language in Safari (#1127) (#1128)

* docs: fix select language in Safari (#1127)

* docs: fix select language top position

* docs: fix select language position

* Make congratsbot not run in forks (#1145)

* add back dark-mode aware favicons

* make example favicons prefer non-dark mode

* Version Packages (next) (#1129)

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

* code review comments

Co-authored-by: Tony Sullivan <[email protected]>
Co-authored-by: Tony Sullivan <[email protected]>
Co-authored-by: matthewp <[email protected]>
Co-authored-by: FredKSchott <[email protected]>
Co-authored-by: Oleg <[email protected]>
Co-authored-by: Marcus Otterström <[email protected]>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@MarcusOtter MarcusOtter deleted the patch-2 branch February 5, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants