Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(plugin-content): code refactor #11312

Merged
merged 6 commits into from
Jun 25, 2024
Merged

Conversation

Simon-He95
Copy link
Contributor

Changes

Concurrent operation to copy files

Testing

Docs

Copy link

changeset-bot bot commented Jun 21, 2024

⚠️ No Changeset found

Latest commit: a2b0147

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Jun 21, 2024
@ematipico
Copy link
Member

ematipico commented Jun 21, 2024

Can you explain to us this refactor a bit more? What does it change? Why is it needed? etc.

Please argument your decisions

@Simon-He95
Copy link
Contributor Author

Can you explain to us this refactor a bit more? What does it change? Why is it needed? etc.

Please argument your decisions

I made some adjustments and waited until the promises had values, because there was no order or dependency in copying files, and I thought parallel processing would be more efficient.

@bluwy bluwy merged commit 02c37c7 into withastro:main Jun 25, 2024
13 checks passed
@Simon-He95 Simon-He95 deleted the refactor branch June 26, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants