Fix body scoping #1130
Fix body scoping #1130
Conversation
🦋 Changeset detectedLatest commit: 71b8156 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is being automatically deployed with Vercel (learn more). astro-www – ./www🔍 Inspect: https://vercel.com/pikapkg/astro-www/Arq2oPmx4humYHiwC5q2Do4xUQCt [Deployment for 71b8156 canceled] astro-docs – ./docs🔍 Inspect: https://vercel.com/pikapkg/astro-docs/8Lbo56xWCyrhDoRq7VzcWPLT3qLg |
| @@ -13,6 +13,11 @@ interface Selector { | |||
| const CSS_SEPARATORS = new Set([' ', ',', '+', '>', '~']); | |||
| const KEYFRAME_PERCENT = /\d+\.?\d*%/; | |||
|
|
|||
| /** minify selector CSS */ | |||
| function minifySelector(selector: string): string { | |||
| return selector.replace(/(\r?\n|\s)+/g, ' ').replace(/\s*(,|\+|>|~|\(|\))\s*/g, '$1'); | |||
There was a problem hiding this comment.
The change here is CSS sanitization. This removes any extraneous whitespace characters (including linebreaks) that aren’t essential to the CSS selector (keeping in mind that some whitespace is essential as child selector, but other whitespace is non-essential such as .foo + \n .bar and can be removed).
The issue was whitespace not being handled properly, resulting in things like body (rather than body) being a selector and incorrectly marked as needing scoping.
Fixes #1074
drwpow
force-pushed
the
fix-body-scoping
branch
from
37d6a68
to
71b8156
Compare
Changes
Fixes #1074. In certain situations, our CSS scoping would encounter unexpected characters and scope classes unnecessarily (like
body). This PR adds better css sanitizationTesting
Test added.
Docs
Bugfix; no docs needed.