Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visible components #112

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Fix visible components #112

merged 2 commits into from
Apr 19, 2021

Conversation

matthewp
Copy link
Contributor

@matthewp matthewp commented Apr 19, 2021

The wrapper component is grabbed with querySelector, so no need for .item() call which was throwing.

Fixes #110

The wrapper component is grabbed with querySelector, so no need for `.item()` call which was throwing.
@natemoo-re natemoo-re linked an issue Apr 19, 2021 that may be closed by this pull request
@natemoo-re
Copy link
Member

LGTM! Thanks. Just missed that when refactoring.

@matthewp matthewp merged commit ea857e6 into main Apr 19, 2021
@matthewp matthewp deleted the visible2 branch April 19, 2021 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

:visible components throw error
2 participants