Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

📘 DOC: Remove font-weight:400; from anchor links #1116

Merged
merged 1 commit into from
Aug 16, 2021

Conversation

jasikpark
Copy link
Contributor

Anchor links should be the same weight as the text without a link.

If we wanted to, we could set the font-weight as heavier maybe? Is that an option? So that it just chooses an increase in font-weight for differentiation from text outside of a link.

This was mainly a problem with headings that have links, the difference in font-weight stuck out like a sore thumb to me.

… weight as the text without a link.

If we wanted to, we *could* set the font-weight as `heavier` maybe? Is that an option? So that it just chooses an increase in font-weight for differentiation from text outside of a link.

This was mainly a problem with headings that have links, the difference in font-weight stuck out like a sore thumb to me.
@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2021

⚠️ No Changeset found

Latest commit: 83c6058

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 15, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

astro-www – ./www

🔍 Inspect: https://vercel.com/pikapkg/astro-www/68Wq3Az1WrHDCsuBLpdK9igNksBd
✅ Preview: Canceled

astro-docs – ./docs

🔍 Inspect: https://vercel.com/pikapkg/astro-docs/64nRgTtfNG7Suehx4FZo1qba2Ud6
✅ Preview: https://astro-docs-git-docs-font-weight-fix-pikapkg.vercel.app

@FredKSchott
Copy link
Member

+1 for matching the body, but also headings probably shouldn't also have links. Do you have an example of this on the docs site today?

@FredKSchott FredKSchott merged commit 9cc3c52 into main Aug 16, 2021
@FredKSchott FredKSchott deleted the docs/font-weight-fix branch August 16, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants