Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: added 2 pages in French #1114

Merged
merged 1 commit into from
Aug 17, 2021
Merged

docs: added 2 pages in French #1114

merged 1 commit into from
Aug 17, 2021

Conversation

GauBen
Copy link
Contributor

@GauBen GauBen commented Aug 14, 2021

Changes

The French documentation has never been this big! 😄

Testing

Hmm, not sure how to test markdown. Maybe add https://github.com/markdownlint/markdownlint in the future?

Docs

Oui, en effet.

@changeset-bot
Copy link

changeset-bot bot commented Aug 14, 2021

⚠️ No Changeset found

Latest commit: dd9054f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 14, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

astro-docs – ./docs

🔍 Inspect: https://vercel.com/pikapkg/astro-docs/Ey9BE53o2fwwEeJ72sppdVaXq7aL
✅ Preview: https://astro-docs-git-fork-gauben-main-pikapkg.vercel.app

astro-www – ./www

🔍 Inspect: https://vercel.com/pikapkg/astro-www/F8FbK7hQhKxoTu4b4ZjLQCk6YKAa
✅ Preview: Canceled

[Deployment for dd9054f canceled]

@jasikpark
Copy link
Contributor

That looks great! The docs don't need added testing in the same sense a feature of code == tests, but it might be a good idea to add a yarn workspace docs lint github action 🤔

@GauBen
Copy link
Contributor Author

GauBen commented Aug 15, 2021

Random ideas for doc linting:

@jasikpark
Copy link
Contributor

You can check Prettier off that list :) We've already got that going

@jasikpark
Copy link
Contributor

Those definitely all seem pretty solid :)

@GauBen
Copy link
Contributor Author

GauBen commented Aug 16, 2021

Fixed a typo

@FredKSchott FredKSchott merged commit 64bbd89 into withastro:main Aug 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants