Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC: Update astro comparisons #1109

Merged
merged 1 commit into from
Aug 16, 2021
Merged

DOC: Update astro comparisons #1109

merged 1 commit into from
Aug 16, 2021

Conversation

FredKSchott
Copy link
Member

  • Add elder.js comparison
  • Add Gatsby comparison
  • update perf audit scores (including a lighthouse bump from 95->99 and a JS payload bump from ~7kb to ~70kb

@changeset-bot
Copy link

changeset-bot bot commented Aug 13, 2021

⚠️ No Changeset found

Latest commit: ead8ac8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Aug 13, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

astro-www – ./www

🔍 Inspect: https://vercel.com/pikapkg/astro-www/6NMMEmtNwyTRGyCLotUTRwTP1DEr
✅ Preview: Canceled

[Deployment for ead8ac8 canceled]

astro-docs – ./docs

🔍 Inspect: https://vercel.com/pikapkg/astro-docs/BYVvjPxypCanrhyH9WPJqLJZchRZ
✅ Preview: https://astro-docs-git-update-astro-comparisons-pikapkg.vercel.app

@RafidMuhymin
Copy link
Member

  • Add elder.js comparison
  • Add Gatsby comparison
  • update perf audit scores (including a lighthouse bump from 95->99 and a JS payload bump from ~7kb to ~70kb

Shouldn’t it be from ~70kb to ~7kb?

@FredKSchott
Copy link
Member Author

it's frustrating, but our Algolia-powered search is only available as a React component, so it forces us to add react-render plus the component itself for an additional ~65kb JS. But, we're smarter about loading JS now using client:visible and client:idle so that it doesn't impact overall page performance.

@FredKSchott FredKSchott merged commit 6322c99 into main Aug 16, 2021
@FredKSchott FredKSchott deleted the update-astro-comparisons branch August 16, 2021 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants