Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(astro): refine assets prefix typing #11020

Merged
merged 1 commit into from
May 14, 2024

Conversation

xsynaptic
Copy link
Contributor

Changes

Add type declarations for import.meta.env.ASSETS_PREFIX when defined as an object for handling different file types.

Testing

No tests should be required, but tests are running OK locally.

Docs

This was already documented here, it just seems to have been missed in the actual codebase.

Copy link

changeset-bot bot commented May 13, 2024

🦋 Changeset detected

Latest commit: 1b69035

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label May 13, 2024
@ematipico ematipico requested a review from a team May 13, 2024 12:22
@bluwy bluwy merged commit 2e2d6b7 into withastro:main May 14, 2024
13 checks passed
@astrobot-houston astrobot-houston mentioned this pull request May 14, 2024
@xsynaptic xsynaptic deleted the fix/refine-asset-prefix-types branch May 14, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants