Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(preact): add support for devtools #10938

Merged
merged 2 commits into from
May 3, 2024
Merged

feat(preact): add support for devtools #10938

merged 2 commits into from
May 3, 2024

Conversation

florian-lefebvre
Copy link
Member

@florian-lefebvre florian-lefebvre commented May 2, 2024

Changes

Testing

Manually in the preact example

Docs

TBD

Copy link

changeset-bot bot commented May 2, 2024

🦋 Changeset detected

Latest commit: bbc6e08

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: preact Related to Preact (scope) pkg: integration Related to any renderer integration (scope) labels May 2, 2024
@florian-lefebvre florian-lefebvre marked this pull request as ready for review May 2, 2024 15:18
@florian-lefebvre florian-lefebvre added this to the 4.8.0 milestone May 2, 2024
@Princesseuh
Copy link
Member

Should all these tools be opt-in? Is there a reason to not want them?

@florian-lefebvre
Copy link
Member Author

florian-lefebvre commented May 2, 2024

We quickly discussed this on Discord iirc and we thought it may be better to leave it disabled for now. Happy to change this if needed tho! In the case of vue, the only issue is that both devtools are on the same location so can be a bit annoying

@matthewp matthewp merged commit fd508a0 into main May 3, 2024
13 checks passed
@matthewp matthewp deleted the feat/preact-devtools branch May 3, 2024 19:21
@astrobot-houston astrobot-houston mentioned this pull request May 3, 2024
@ematipico ematipico modified the milestone: 4.8.0 May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: integration Related to any renderer integration (scope) pkg: preact Related to Preact (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants