Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add new component to toolbar library #10906

Merged
merged 3 commits into from
May 8, 2024
Merged

Conversation

Princesseuh
Copy link
Member

@Princesseuh Princesseuh commented Apr 29, 2024

Changes

Adds a new radio checkbox component and a way to make rounded buttons, for things like floating pluses UI and stuff

These two were some of the components that were supposed to be added when the toolbar was first released, but fell through as they were not needed for the built-in components.

Testing

Tested manually

Docs

Working on it!

Copy link

changeset-bot bot commented Apr 29, 2024

🦋 Changeset detected

Latest commit: de86dc3

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review labels Apr 29, 2024
@Princesseuh Princesseuh changed the title feat: new toolbar components feat: Add new component to toolbar library Apr 29, 2024
@github-actions github-actions bot added the semver: minor Change triggers a `minor` release label Apr 29, 2024
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is blocked because it contains a minor changeset. A reviewer will merge this at the next release if approved.

@Princesseuh Princesseuh added this to the 4.8.0 milestone Apr 29, 2024
@Princesseuh Princesseuh marked this pull request as ready for review April 29, 2024 14:33
Copy link
Member

@sarah11918 sarah11918 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving for docs! 🥳

@ematipico ematipico merged commit 7bbd664 into main May 8, 2024
14 checks passed
@ematipico ematipico deleted the feat/new-toolbar-components branch May 8, 2024 09:26
@astrobot-houston astrobot-houston mentioned this pull request May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pr: docs A PR that includes documentation for review semver: minor Change triggers a `minor` release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants