Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Astro.resolve #1085

Merged
merged 9 commits into from
Aug 16, 2021
Merged

Astro.resolve #1085

Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
6ced818
add: Astro.resolve
jonathantneal Aug 10, 2021
66d4b7c
Add docs and tests for Astro.resolve
matthewp Aug 11, 2021
aa8489e
Add warnings when using string literals
matthewp Aug 11, 2021
af3e8c5
Prevent windows errors
matthewp Aug 11, 2021
c7475eb
Adds a changeset
matthewp Aug 11, 2021
331dfaf
Use the astro logger to log the warning
matthewp Aug 16, 2021
55c08e3
Use the .js extension
matthewp Aug 16, 2021
7c106ea
Dont warn for data urls
matthewp Aug 16, 2021
9fc2aad
Rename nonRelative and better match
matthewp Aug 16, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Rename nonRelative and better match
  • Loading branch information
@matthewp
matthewp committed Aug 16, 2021
commit 9fc2aad4ce03f8d6e21c44f141773afa7610c7b1
4 changes: 2 additions & 2 deletions packages/astro/src/compiler/codegen/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ const warnableRelativeValues = new Set([
'source+srcset'
]);

const nonRelative = /^(?!(https?:|data:|\/))/;
const matchesRelative = /^(?![A-Za-z][+-.0-9A-Za-z]*:|\/)/;

export function warnIfRelativeStringLiteral(logging: LogOptions, nodeName: string, attr: Attribute, value: string) {
let key = nodeName + '+' + attr.name;
if(warnableRelativeValues.has(key) && nonRelative.test(value)) {
if(warnableRelativeValues.has(key) && matchesRelative.test(value)) {
let message = `This value will be resolved relative to the page: <${nodeName} ${attr.name}="${value}">`;
warn(logging, 'relative-link', message);
}
Expand Down