Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install-package): Automatically exit in CI instead of waiting for input #10669

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

Princesseuh
Copy link
Member

Changes

Rarely, someone run a project in CI that doesn't have astro check or typescript (or now, @astrojs/db) and the CLI stall infinitely waiting for someone, out there, to press a button. This PR makes it so it fails instantly now in CI.

Testing

Tested manually by inverting the checks locally

Docs

N/A

Copy link

changeset-bot bot commented Apr 3, 2024

🦋 Changeset detected

Latest commit: f2ed8be

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the pkg: astro Related to the core `astro` package (scope) label Apr 3, 2024
@bluwy bluwy merged commit 0464563 into main Apr 4, 2024
13 checks passed
@bluwy bluwy deleted the fix/exit-ci-install branch April 4, 2024 07:08
@astrobot-houston astrobot-houston mentioned this pull request Apr 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants