Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(types): Fixes HTMLAttribute extend to allow everything #10561

Merged
merged 3 commits into from
Mar 26, 2024
Merged

fix(types): Fixes HTMLAttribute extend to allow everything #10561

merged 3 commits into from
Mar 26, 2024

Conversation

Princesseuh
Copy link
Member

@Princesseuh Princesseuh commented Mar 26, 2024 •
edited
Loading

Changes

The type in #10549 didn't allow enough stuff and the key was too wide. This fixes that

Testing

Tested manually + astro check should pass

Docs

N/A

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: cab0bff

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added 🚨 action Modifies GitHub Actions pkg: astro Related to the core `astro` package (scope) labels Mar 26, 2024
Fryuni
Fryuni reviewed Mar 26, 2024
View reviewed changes
packages/astro/types.d.ts Outdated Show resolved Hide resolved
ematipico
ematipico approved these changes Mar 26, 2024
View reviewed changes
Copy link
Member

@ematipico ematipico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this PR require a changeset?

@Princesseuh
Copy link
Member Author

Does this PR require a changeset?

No, it's a fix to an unreleased thing.

@Princesseuh Princesseuh mentioned this pull request Mar 26, 2024
Merged
@Princesseuh Princesseuh merged commit 51a4ea5 into main Mar 26, 2024
14 checks passed
@Princesseuh Princesseuh deleted the fix/html-attribute-type branch March 26, 2024 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fryuni Fryuni Fryuni left review comments

@ematipico ematipico ematipico approved these changes

@florian-lefebvre florian-lefebvre florian-lefebvre approved these changes

Assignees
No one assigned
Labels
🚨 action Modifies GitHub Actions pkg: astro Related to the core `astro` package (scope)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Princesseuh @ematipico @Fryuni @florian-lefebvre