Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Vite 5.1 #10120

Merged
merged 2 commits into from
Feb 15, 2024
Merged

Update to Vite 5.1 #10120

merged 2 commits into from
Feb 15, 2024

Conversation

bluwy
Copy link
Member

@bluwy bluwy commented Feb 15, 2024

Changes

Update to Vite 5.1. Also handle the type changes for vite.build.assetsInlineLimit that now accepts a function. Other than that, it's just a version bump.

Vite 5.1 has other features that should trim down our code too that I'll send as separate PRs later.

Testing

Existing tests should pass.

Docs

n/a. version upgrade.

Copy link

changeset-bot bot commented Feb 15, 2024

🦋 Changeset detected

Latest commit: a32881e

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope) pkg: react Related to React (scope) pkg: integration Related to any renderer integration (scope) pkg: astro Related to the core `astro` package (scope) labels Feb 15, 2024
return result;
}

return Buffer.byteLength(assetContent) < 4096; // Fallback to 4096kb by default (same as Vite)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice if Vite would expose this default. Something to think about :)

@bluwy bluwy merged commit 787e6f5 into main Feb 15, 2024
13 checks passed
@bluwy bluwy deleted the vite-5.1 branch February 15, 2024 09:20
@astrobot-houston astrobot-houston mentioned this pull request Feb 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pkg: astro Related to the core `astro` package (scope) pkg: integration Related to any renderer integration (scope) pkg: react Related to React (scope) pkg: svelte Related to Svelte (scope) pkg: vue Related to Vue (scope)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants