Initial tests set up #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthewp
force-pushed
the
debugging-markdown
branch
from
ac3cc7d
to
2f390e9
Compare
matthewp
commented
Mar 19, 2021
drwpow
reviewed
Mar 19, 2021
| @@ -0,0 +1,26 @@ | |||
| name: Node CI | |||
There was a problem hiding this comment.
Just a note: we need to make sure that billing is enabled since this is a private repo to use this action
There was a problem hiding this comment.
(GitHub Actions is only free for public repos)
There was a problem hiding this comment.
Oh, I didn't realize that. I can always remove this file if we'd rather wait.
There was a problem hiding this comment.
Oh yeah that’s why I didn’t add the format-on-commit action here yet
drwpow
reviewed
Mar 19, 2021
| try { | ||
| const result = await snowpack.loadUrl(reqPath); | ||
| switch(result.statusCode) { | ||
| case 200: { |
There was a problem hiding this comment.
Very nice! I will always appreciate a good switch
drwpow
approved these changes
Mar 19, 2021
This adds tests using uvu (we can switch if people want) and restructures things a bit so that it's easier to test.
Like in snowpack you set up a little project. In our tests you can say:
```js
const result = await runtime.load('/blog/hello-world')
```
And analyze the result. I included a `test-helpers.js` which has a function that will turn HTML into a cheerio instance, for inspecting the result HTML.
matthewp
force-pushed
the
debugging-markdown
branch
from
8a79ad1
to
7ed2b00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests using uvu (we can switch if people want) and restructures things a bit so that it's easier to test.
Like in snowpack you set up a little project. In our tests you can say:
And analyze the result. I included a
test-helpers.jswhich has a function that will turn HTML into a cheerio instance, for inspecting the result HTML.