nit: use node: prefix everywhere (#7692)

* nit: use `node:` prefix everywhere

* nit: fs/promises too

* test: workaround issue in node builtin detection

.github/scripts/bundle-size.mjs

@@ -1,5 +1,5 @@
 import { build } from 'esbuild';
-import { existsSync } from 'fs';
+import { existsSync } from 'node:fs';
 
 const CLIENT_RUNTIME_PATH = 'packages/astro/src/runtime/client/';
 
@@ -27,13 +27,13 @@ export default async function checkBundleSize({ github, context }) {
  return file.filename.startsWith(CLIENT_RUNTIME_PATH) && file.status !== 'removed'
  });
  if (clientRuntimeFiles.length === 0) return;
- 
+
  const table = [
  '| File | Old Size | New Size | Change |',
  '| ---- | -------- | -------- | ------ |',
  ];
  const output = await bundle(clientRuntimeFiles);
- 
+
  for (let [filename, { oldSize, newSize, sourceFile }] of Object.entries(output)) {
  filename = ['idle', 'load', 'media', 'only', 'visible'].includes(filename) ? `client:${filename}` : filename;
  const prefix = (newSize - oldSize) === 0 ? '' : (newSize - oldSize) > 0 ? '+ ' : '- ';
@@ -60,7 +60,7 @@ ${table.join('\n')}`,
 }
 
 async function bundle(files) {
- 
+
  const { metafile } = await build({
  entryPoints: [...files.map(({ filename }) => filename), ...files.map(({ filename }) => `main/${filename}`).filter(f => existsSync(f))],
  bundle: true,

benchmark/bench/cli-startup.js

@@ -1,4 +1,4 @@
-import { fileURLToPath } from 'url';
+import { fileURLToPath } from 'node:url';
 import { execaCommand } from 'execa';
 import { markdownTable } from 'markdown-table';
 import { astroBin, calculateStat } from './_util.js';

benchmark/bench/memory.js

@@ -1,7 +1,7 @@
-import fs from 'fs/promises';
-import { fileURLToPath } from 'url';
 import { execaCommand } from 'execa';
 import { markdownTable } from 'markdown-table';
+import fs from 'node:fs/promises';
+import { fileURLToPath } from 'node:url';
 import { astroBin } from './_util.js';
 
 /** @typedef {Record<string, import('../../packages/astro/src/core/config/timer').Stat>} AstroTimerStat */

benchmark/bench/render.js

@@ -1,12 +1,12 @@
-import fs from 'fs/promises';
-import http from 'http';
-import path from 'path';
-import { fileURLToPath } from 'url';
 import { execaCommand } from 'execa';
-import { waitUntilBusy } from 'port-authority';
 import { markdownTable } from 'markdown-table';
-import { renderFiles } from '../make-project/render-default.js';
+import fs from 'node:fs/promises';
+import http from 'node:http';
+import path from 'node:path';
+import { fileURLToPath } from 'node:url';
+import { waitUntilBusy } from 'port-authority';
 import { calculateStat } from '../make-project/_util.js';
+import { renderFiles } from '../make-project/render-default.js';
 import { astroBin } from './_util.js';
 
 const port = 4322;

benchmark/bench/server-stress.js

@@ -1,9 +1,9 @@
-import fs from 'fs/promises';
-import { fileURLToPath } from 'url';
 import autocannon from 'autocannon';
 import { execaCommand } from 'execa';
-import { waitUntilBusy } from 'port-authority';
 import { markdownTable } from 'markdown-table';
+import fs from 'node:fs/promises';
+import { fileURLToPath } from 'node:url';
+import { waitUntilBusy } from 'port-authority';
 import pb from 'pretty-bytes';
 import { astroBin } from './_util.js';
 

benchmark/index.js

@@ -1,7 +1,7 @@
-import fs from 'fs/promises';
-import path from 'path';
-import { pathToFileURL } from 'url';
 import mri from 'mri';
+import fs from 'node:fs/promises';
+import path from 'node:path';
+import { pathToFileURL } from 'node:url';
 
 const args = mri(process.argv.slice(2));
 

benchmark/make-project/memory-default.js

@@ -1,4 +1,4 @@
-import fs from 'fs/promises';
+import fs from 'node:fs/promises';
 import { loremIpsum } from './_util.js';
 
 /**

benchmark/make-project/render-default.js

@@ -1,4 +1,4 @@
-import fs from 'fs/promises';
+import fs from 'node:fs/promises';
 import { loremIpsumHtml, loremIpsumMd } from './_util.js';
 
 // Map of files to be generated and tested for rendering.

benchmark/make-project/server-stress-default.js

@@ -1,4 +1,4 @@
-import fs from 'fs/promises';
+import fs from 'node:fs/promises';
 import { loremIpsum } from './_util.js';
 
 /**

benchmark/packages/timer/src/preview.ts

@@ -1,5 +1,5 @@
 import type { CreatePreviewServer } from 'astro';
-import { createServer } from 'http';
+import { createServer } from 'node:http';
 import enableDestroy from 'server-destroy';
 
 const preview: CreatePreviewServer = async function ({ serverEntrypoint, host, port }) {

benchmark/packages/timer/src/server.ts

@@ -1,7 +1,7 @@
 import { polyfill } from '@astrojs/webapi';
 import type { SSRManifest } from 'astro';
 import { NodeApp } from 'astro/app/node';
-import type { IncomingMessage, ServerResponse } from 'http';
+import type { IncomingMessage, ServerResponse } from 'node:http';
 
 polyfill(globalThis, {
  exclude: 'window document',

packages/astro/e2e/fixtures/custom-client-directives/astro.config.mjs

@@ -1,6 +1,6 @@
 import { defineConfig } from 'astro/config';
 import react from "@astrojs/react";
-import { fileURLToPath } from 'url';
+import { fileURLToPath } from 'node:url';
 
 export default defineConfig({
  integrations: [astroClientClickDirective(), astroClientPasswordDirective(), react()],

packages/astro/e2e/fixtures/tailwindcss/astro.config.mjs

@@ -1,6 +1,6 @@
 import { defineConfig } from 'astro/config';
 import tailwind from '@astrojs/tailwind';
-import { fileURLToPath } from 'url';
+import { fileURLToPath } from 'node:url';
 
 // https://astro.build/config
 export default defineConfig({

packages/astro/e2e/fixtures/tailwindcss/tailwind.config.js

@@ -1,4 +1,4 @@
-const path = require('path');
+const path = require('node:path');
 
 module.exports = {
  content: [path.join(__dirname, 'src/**/*.{astro,html,js,jsx,md,mdx,svelte,ts,tsx,vue}')],

packages/astro/e2e/test-utils.js

@@ -1,6 +1,6 @@
-import fs from 'fs/promises';
-import path from 'path';
-import { test as testBase, expect } from '@playwright/test';
+import { expect, test as testBase } from '@playwright/test';
+import fs from 'node:fs/promises';
+import path from 'node:path';
 import { loadFixture as baseLoadFixture } from '../test/test-utils.js';
 
 export const isWindows = process.platform === 'win32';

packages/astro/performance/content-benchmark.mjs

@@ -1,6 +1,6 @@
 /* eslint-disable no-console */
 
-import { fileURLToPath } from 'url';
+import { fileURLToPath } from 'node:url';
 import { loadFixture } from '../test/test-utils.js';
 import { generatePosts } from './scripts/generate-posts.mjs';
 import yargs from 'yargs-parser';

packages/astro/performance/scripts/generate-posts.mjs

@@ -1,5 +1,5 @@
-import fs from 'fs';
-import path from 'path';
+import fs from 'node:fs';
+import path from 'node:path';
 
 const NUM_POSTS = 10;
 const POSTS_DIR = './src/content/posts.generated';

packages/astro/scripts/shiki-gen-languages.mjs

@@ -1,4 +1,4 @@
-import fs from 'fs';
+import fs from 'node:fs';
 
 const dir = await fs.promises.readdir('packages/astro/node_modules/shiki/languages/');
 

packages/astro/scripts/shiki-gen-themes.mjs

@@ -1,4 +1,4 @@
-import fs from 'fs';
+import fs from 'node:fs';
 
 const dir = await fs.promises.readdir('packages/astro/node_modules/shiki/themes/');
 

packages/astro/src/@types/astro.ts

@@ -8,8 +8,8 @@ import type {
  ShikiConfig,
 } from '@astrojs/markdown-remark';
 import type * as babel from '@babel/core';
-import type { OutgoingHttpHeaders } from 'http';
-import type { AddressInfo } from 'net';
+import type { OutgoingHttpHeaders } from 'node:http';
+import type { AddressInfo } from 'node:net';
 import type * as rollup from 'rollup';
 import type { TsConfigJson } from 'tsconfig-resolver';
 import type * as vite from 'vite';

packages/astro/src/assets/services/vendor/squoosh/avif/avif_node_dec.ts

@@ -41,13 +41,13 @@ var Module = (function () {
  var nodePath
  if (ENVIRONMENT_IS_NODE) {
  if (ENVIRONMENT_IS_WORKER) {
- scriptDirectory = require('path').dirname(scriptDirectory) + '/'
+ scriptDirectory = require('node:path').dirname(scriptDirectory) + '/'
  } else {
  scriptDirectory = dirname(getModuleURL(import.meta.url)) + '/'
  }
  read_ = function shell_read(filename, binary) {
- if (!nodeFS) nodeFS = require('fs')
- if (!nodePath) nodePath = require('path')
+ if (!nodeFS) nodeFS = require('node:fs')
+ if (!nodePath) nodePath = require('node:path')
  filename = nodePath['normalize'](filename)
  return nodeFS['readFileSync'](filename, binary ? null : 'utf8')
  }

packages/astro/src/assets/services/vendor/squoosh/avif/avif_node_enc.ts

@@ -41,13 +41,13 @@ var Module = (function () {
  var nodePath
  if (ENVIRONMENT_IS_NODE) {
  if (ENVIRONMENT_IS_WORKER) {
- scriptDirectory = require('path').dirname(scriptDirectory) + '/'
+ scriptDirectory = require('node:path').dirname(scriptDirectory) + '/'
  } else {
  scriptDirectory = dirname(getModuleURL(import.meta.url)) + '/'
  }
  read_ = function shell_read(filename, binary) {
- if (!nodeFS) nodeFS = require('fs')
- if (!nodePath) nodePath = require('path')
+ if (!nodeFS) nodeFS = require('node:fs')
+ if (!nodePath) nodePath = require('node:path')
  filename = nodePath['normalize'](filename)
  return nodeFS['readFileSync'](filename, binary ? null : 'utf8')
  }

packages/astro/src/assets/services/vendor/squoosh/image-pool.ts

@@ -1,6 +1,6 @@
+import { cpus } from 'node:os';
+import { fileURLToPath } from 'node:url';
 import { isMainThread } from 'node:worker_threads';
-import { cpus } from 'os';
-import { fileURLToPath } from 'url';
 import type { ImageOutputFormat } from '../../../types.js';
 import { getModuleURL } from './emscripten-utils.js';
 import type { Operation } from './image.js';

packages/astro/src/assets/services/vendor/squoosh/mozjpeg/mozjpeg_node_dec.ts

@@ -41,13 +41,13 @@ var Module = (function () {
  var nodePath
  if (ENVIRONMENT_IS_NODE) {
  if (ENVIRONMENT_IS_WORKER) {
- scriptDirectory = require('path').dirname(scriptDirectory) + '/'
+ scriptDirectory = require('node:path').dirname(scriptDirectory) + '/'
  } else {
  scriptDirectory = dirname(getModuleURL(import.meta.url)) + '/'
  }
  read_ = function shell_read(filename, binary) {
- if (!nodeFS) nodeFS = require('fs')
- if (!nodePath) nodePath = require('path')
+ if (!nodeFS) nodeFS = require('node:fs')
+ if (!nodePath) nodePath = require('node:path')
  filename = nodePath['normalize'](filename)
  return nodeFS['readFileSync'](filename, binary ? null : 'utf8')
  }

packages/astro/src/assets/services/vendor/squoosh/mozjpeg/mozjpeg_node_enc.ts

@@ -41,13 +41,13 @@ var Module = (function () {
  var nodePath
  if (ENVIRONMENT_IS_NODE) {
  if (ENVIRONMENT_IS_WORKER) {
- scriptDirectory = require('path').dirname(scriptDirectory) + '/'
+ scriptDirectory = require('node:path').dirname(scriptDirectory) + '/'
  } else {
  scriptDirectory = dirname(getModuleURL(import.meta.url)) + '/'
  }
  read_ = function shell_read(filename, binary) {
- if (!nodeFS) nodeFS = require('fs')
- if (!nodePath) nodePath = require('path')
+ if (!nodeFS) nodeFS = require('node:fs')
+ if (!nodePath) nodePath = require('node:path')
  filename = nodePath['normalize'](filename)
  return nodeFS['readFileSync'](filename, binary ? null : 'utf8')
  }

packages/astro/src/assets/services/vendor/squoosh/webp/webp_node_dec.ts

@@ -41,13 +41,13 @@ var Module = (function () {
  var nodePath
  if (ENVIRONMENT_IS_NODE) {
  if (ENVIRONMENT_IS_WORKER) {
- scriptDirectory = require('path').dirname(scriptDirectory) + '/'
+ scriptDirectory = require('node:path').dirname(scriptDirectory) + '/'
  } else {
  scriptDirectory = dirname(getModuleURL(import.meta.url)) + '/'
  }
  read_ = function shell_read(filename, binary) {
- if (!nodeFS) nodeFS = require('fs')
- if (!nodePath) nodePath = require('path')
+ if (!nodeFS) nodeFS = require('node:fs')
+ if (!nodePath) nodePath = require('node:path')
  filename = nodePath['normalize'](filename)
  return nodeFS['readFileSync'](filename, binary ? null : 'utf8')
  }

packages/astro/src/assets/services/vendor/squoosh/webp/webp_node_enc.ts

@@ -41,13 +41,13 @@ var Module = (function () {
  var nodePath
  if (ENVIRONMENT_IS_NODE) {
  if (ENVIRONMENT_IS_WORKER) {
- scriptDirectory = require('path').dirname(scriptDirectory) + '/'
+ scriptDirectory = require('node:path').dirname(scriptDirectory) + '/'
  } else {
  scriptDirectory = dirname(getModuleURL(import.meta.url)) + '/'
  }
  read_ = function shell_read(filename, binary) {
- if (!nodeFS) nodeFS = require('fs')
- if (!nodePath) nodePath = require('path')
+ if (!nodeFS) nodeFS = require('node:fs')
+ if (!nodePath) nodePath = require('node:path')
  filename = nodePath['normalize'](filename)
  return nodeFS['readFileSync'](filename, binary ? null : 'utf8')
  }

packages/astro/src/assets/utils/transformToPath.ts

@@ -1,4 +1,4 @@
-import { basename, extname } from 'path';
+import { basename, extname } from 'node:path';
 import { removeQueryString } from '../../core/path.js';
 import { shorthash } from '../../runtime/server/shorthash.js';
 import { isESMImportedImage } from '../internal.js';

packages/astro/src/assets/vendor/image-size/index.ts

@@ -1,5 +1,5 @@
-import * as fs from "fs";
-import * as path from "path";
+import * as fs from "node:fs";
+import * as path from "node:path";
 import Queue from "../queue/queue.js";
 import { detector } from "./detector.js";
 import { typeHandlers, type imageType } from "./types.js";

packages/astro/src/assets/vendor/image-size/types/tiff.ts

@@ -1,6 +1,6 @@
 // based on https://www.compix.com/fileformattif.htm
 // TO-DO: support big-endian as well
-import * as fs from 'fs'
+import * as fs from 'node:fs'
 import { readUInt } from '../readUInt.js'
 import type { IImage } from './interface'
 

packages/astro/src/cli/add/index.ts

@@ -1,13 +1,13 @@
 import boxen from 'boxen';
 import { diffWords } from 'diff';
 import { execa } from 'execa';
-import fsMod, { existsSync, promises as fs } from 'fs';
 import { bold, cyan, dim, green, magenta, red, yellow } from 'kleur/colors';
+import fsMod, { existsSync, promises as fs } from 'node:fs';
+import path from 'node:path';
+import { fileURLToPath, pathToFileURL } from 'node:url';
 import ora from 'ora';
-import path from 'path';
 import preferredPM from 'preferred-pm';
 import prompts from 'prompts';
-import { fileURLToPath, pathToFileURL } from 'url';
 import type yargs from 'yargs-parser';
 import { loadTSConfig, resolveConfigPath } from '../../core/config/index.js';
 import {

packages/astro/src/cli/check/index.ts

@@ -5,12 +5,12 @@ import {
 } from '@astrojs/language-server';
 import type { FSWatcher } from 'chokidar';
 import glob from 'fast-glob';
-import fs from 'fs';
 import { bold, dim, red, yellow } from 'kleur/colors';
 import { createRequire } from 'module';
+import fs from 'node:fs';
 import { join } from 'node:path';
+import { fileURLToPath, pathToFileURL } from 'node:url';
 import ora from 'ora';
-import { fileURLToPath, pathToFileURL } from 'url';
 import type { Arguments as Flags } from 'yargs-parser';
 import type { AstroSettings } from '../../@types/astro';
 import type { LogOptions } from '../../core/logger/core.js';

packages/astro/src/cli/check/print.ts

@@ -12,7 +12,7 @@ import {
  yellow,
 } from 'kleur/colors';
 import stringWidth from 'string-width';
-import { fileURLToPath } from 'url';
+import { fileURLToPath } from 'node:url';
 
 export function printDiagnostic(filePath: string, text: string, diag: Diagnostic): string {
  let result = [];

packages/astro/src/cli/dev/index.ts

@@ -1,4 +1,4 @@
-import fs from 'fs';
+import fs from 'node:fs';
 import type yargs from 'yargs-parser';
 import { resolveConfigPath, resolveFlags } from '../../core/config/index.js';
 import devServer from '../../core/dev/index.js';

packages/astro/src/cli/load-settings.ts

@@ -1,6 +1,6 @@
 /* eslint-disable no-console */
-import fs from 'fs';
 import * as colors from 'kleur/colors';
+import fs from 'node:fs';
 import type { Arguments as Flags } from 'yargs-parser';
 import { ZodError } from 'zod';
 import { createSettings, openConfig, resolveConfigPath } from '../core/config/index.js';

packages/astro/src/cli/sync/index.ts

@@ -1,4 +1,4 @@
-import fs from 'fs';
+import fs from 'node:fs';
 import type yargs from 'yargs-parser';
 import type { LogOptions } from '../../core/logger/core.js';
 import { syncCli } from '../../core/sync/index.js';

packages/astro/src/config/index.ts

@@ -22,7 +22,7 @@ export function getViteConfig(inlineConfig: UserConfig) {
  { runHookConfigSetup, runHookConfigDone },
  { astroContentListenPlugin },
  ] = await Promise.all([
- import('fs'),
+ import('node:fs'),
  import('vite'),
  import('../core/logger/node.js'),
  import('../core/config/index.js'),