Skip to content

Commit

Permalink
Investiging a flaky error test (#3613)
Browse files Browse the repository at this point in the history
* restarting dev server between each error test

* re-enabling the test on Linux CI

* trying separate describe() suites per error test

* narrowed the issue down, disabling for more investigation

* not: removing unrelated whitespace change
  • Loading branch information
Tony Sullivan committed Jun 16, 2022
1 parent 9716747 commit e02097d
Showing 1 changed file with 13 additions and 7 deletions.
20 changes: 13 additions & 7 deletions packages/astro/test/errors.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,6 @@ import * as cheerio from 'cheerio';
describe('Error display', () => {
if (isWindows) return;

// TODO: Ubuntu CI runs hit a reliability problem with more than one test in this suite.
// Re-enable this suite once that issue is tracked down.
if (isLinux) return;

/** @type {import('./test-utils').Fixture} */
let fixture;

Expand All @@ -18,14 +14,24 @@ describe('Error display', () => {
});
});

describe('Astro', async () => {
/**
* TODO: Track down reliability issue
*
* After fixing a syntax error on one page, the dev server hangs on the hmr.js request.
* This is specific to a project that has other framework component errors,
* in this case the fixture has multiple broken pages and components.
*
* The issue could be internal to vite, the hmr.js request triggers connect:dispatcher
* events but vite:load is never actually called.
*/
describe.skip('Astro template syntax', async () => {
let devServer;

before(async () => {
beforeEach(async () => {
devServer = await fixture.startDevServer();
});

after(async () => {
afterEach(async () => {
await devServer.stop();
});

Expand Down

0 comments on commit e02097d

Please sign in to comment.