fix(vercel): handle dots in source path for redirects (#9289)

* add fix * add test * add changeset
withastro · Dec 11, 2023 · 8aeb0b5 · 8aeb0b5
1 parent 8aa17a6
commit 8aeb0b5
Show file tree

Hide file tree

Showing 3 changed files with 17 additions and 2 deletions.
diff --git a/.changeset/rotten-socks-help.md b/.changeset/rotten-socks-help.md
@@ -0,0 +1,5 @@
+---
+'@astrojs/vercel': patch
+---
+
+Fixes an issue where dots in redirects were incorrectly handled.
diff --git a/packages/integrations/vercel/src/lib/redirects.ts b/packages/integrations/vercel/src/lib/redirects.ts
@@ -32,11 +32,11 @@ function getMatchPattern(segments: RoutePart[][]) {
  .replace(/#/g, '%23')
  .replace(/%5B/g, '[')
  .replace(/%5D/g, ']')
- .replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+ .replace(/[*+?^${}()|[\]\\]/g, '\\$&');
  })
  .join('');
  })
- .join('');
+ .join('/');
 }
 
 function getReplacePattern(segments: RoutePart[][]) {

diff --git a/packages/integrations/vercel/test/redirects.test.js b/packages/integrations/vercel/test/redirects.test.js
@@ -16,6 +16,7 @@ describe('Redirects', () => {
  destination: '/',
  },
  '/blog/[...slug]': '/team/articles/[...slug]',
+ '/Basic/http-2-0.html': '/posts/http2',
  },
  trailingSlash: 'always',
  });
@@ -45,6 +46,15 @@ describe('Redirects', () => {
  expect(threeRoute.status).to.equal(302);
  });
 
+ it('define redirects for static files', async () => {
+ const config = await getConfig();
+
+ const staticRoute = config.routes.find((r) => r.src === '/Basic/http-2-0.html');
+ expect(staticRoute).to.not.be.undefined;
+ expect(staticRoute.headers.Location).to.equal('/posts/http2');
+ expect(staticRoute.status).to.equal(301);
+ });
+
  it('defines dynamic routes', async () => {
  const config = await getConfig();