Add AWS SSE support on a per request basis #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caquillo07
approved these changes
Jan 3, 2023
acj
approved these changes
Jan 3, 2023
| @@ -156,6 +156,7 @@ type S3Store struct { | |||
| // CPU, so it might be desirable to disable them. | |||
| // Note that this property is experimental and might be removed in the future! | |||
| DisableContentHashes bool | |||
| SSEPattern string | |||
There was a problem hiding this comment.
Suggested change
| SSEPattern string | |
| // SSEPattern is the the server-side encryption algorithm to use when new objects | |
| // are created in S3 (for example, AES256, aws:kms). An empty string ("", the | |
| // default value) will disable SSE. | |
| SSEPattern string |
|
|
||
| assert.Equal("bucket", store.Bucket) | ||
| assert.Equal(s3obj, store.Service) | ||
| assert.Equal(sSEPattern, store.SSEPattern) |
There was a problem hiding this comment.
I'd suggest leaving this one out since you just set it a few lines earlier, and you haven't run any operations on the store since then.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for setting an SSE pattern on each object request. It is expect that SSE is set on the s3Store and it is then applied during the multipart upload and put requests sent to s3. A valid SSE pattern must be provided based on the AWS Documentation. If no value is provided, SSE is not added to the request and it works the same as it did before.