Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add commit input #11

Merged
merged 2 commits into from
Apr 5, 2022
Merged

refactor: add commit input #11

merged 2 commits into from
Apr 5, 2022

Conversation

okize
Copy link
Contributor

@okize okize commented Apr 5, 2022

context.payload.after only worked after subsequent pushes to a PR (ie. the initial opening of the PR caused a failure because commitHash would be undefined). I couldn't find a reliable source of the hash in context so instead we pass it in via github.event.pull_request.head.sha.

note that github.sha doesn't work for reasons explained here: https://stackoverflow.com/a/68068674

@okize okize merged commit 93cec0a into main Apr 5, 2022
@okize okize deleted the mew/add_commit_input branch April 5, 2022 00:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant