runfix: update the view on opening deep link from the connect tab (WPB-9507) #17812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #17812 +/- ##
==========================================
- Coverage 46.39% 46.37% -0.02%
==========================================
Files 771 771
Lines 25164 25164
Branches 5752 5752
==========================================
- Hits 11675 11671 -4
- Misses 12013 12016 +3
- Partials 1476 1477 +1 |
PatrykBuniX
reviewed
Jul 24, 2024
| @@ -60,7 +60,8 @@ const useSidebarStore = create<SidebarStore>()( | |||
| storage: createJSONStorage(() => localStorage), | |||
| partialize: state => ({ | |||
| status: state.status, | |||
| currentTab: state.currentTab === SidebarTabs.PREFERENCES ? SidebarTabs.RECENT : state.currentTab, | |||
| currentTab: | |||
| state.currentTab === SidebarTabs.PREFERENCES || SidebarTabs.CONNECT ? SidebarTabs.RECENT : state.currentTab, | |||
There was a problem hiding this comment.
Shouldn't it be more like [SidebarTabs.PREFERENCES, SidebarTabs.CONNECT].includes(state.currentTab) ? SidebarTabs.RECENT : state.currentTab
if state.currentTab is different than preferences, it will resolve to false and go to OR statement and then SidebarTabs.CONNECT itself is always truthy so it will always be SidebarTabs.RECENT 🤔
PatrykBuniX
approved these changes
Jul 24, 2024
|
thisisamir98
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Opening a deep link from the connect tab should switch the sidebar to a view where the conversation is displayed, this switches to the Recent view
Since the app initialize opening the last conversation, we do not store the state of the sidebar when it's set to Connect (in addition to Preferences), since this state does not show the conversation list