Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: replacing ciphersuites when enroling [WPB-10236] #17806

Merged
merged 4 commits into from
Jul 23, 2024
Merged

fix: replacing ciphersuites when enroling [WPB-10236] #17806

merged 4 commits into from
Jul 23, 2024

Conversation

PatrykBuniX
Copy link
Contributor

@PatrykBuniX PatrykBuniX commented Jul 22, 2024 •
edited by github-actions bot

BugWPB-10236 Generating e2ei certificate fails on bund-next-column-1 backend

Description

Fixes an issue with replacing mls keys by adding ciphersuites param to the PUT request. For more details see wireapp/wire-web-packages#6400

Checklist

  • PR has been self reviewed by the author;
  • Hard-to-understand areas of the code have been commented;
  • If it is a core feature, unit tests have been added;

@PatrykBuniX PatrykBuniX requested review from otto-the-bot and a team as code owners July 22, 2024 15:11
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jul 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@PatrykBuniX PatrykBuniX merged commit c6e496a into release/q1-2024 Jul 23, 2024
10 checks passed
@PatrykBuniX PatrykBuniX deleted the fix/replacing-ciphersuites branch July 23, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thisisamir98 thisisamir98 thisisamir98 approved these changes

@V-Gira V-Gira V-Gira approved these changes

@otto-the-bot otto-the-bot Awaiting requested review from otto-the-bot otto-the-bot is a code owner

Assignees
No one assigned
Labels
👕 size: S type: bug / fix 🐞
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@PatrykBuniX @thisisamir98 @V-Gira @otto-the-bot