-
Notifications
You must be signed in to change notification settings - Fork 323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up Wire.Subsystem module structure #4081
base: develop
Are you sure you want to change the base?
Conversation
0d0267e
to
ca91152
Compare
ca91152
to
5738080
Compare
I have a couple of questions:
I somehow like the idea of a flatter directory structure so I think that |
Could you please write about the motivation for this work, nothing in JIRA or README or the PR description seem to have it captured, so its hard to even engage with this PR. Still here are somethings that could make it better:
All said, it would be best to first define our reasons for this then spend more time into it if we feel its justified. |
no, we'll either keep it as an incomplete sample, marking it as such, or remove it entirely. it's not that hard to look for yourself after all. i just put it there for now so people can see what i mean.
no strong opinion / open to suggestions. the reason was that Eff interpreters only implement one polysemy effects in terms of others, so it's not cassandra, but a polysemy what about
sure, |
https://wearezeta.atlassian.net/browse/WPB-9597
(inspired by https://wearezeta.atlassian.net/browse/WPB-8880)
Checklist
changelog.d